Hi,
For the daring, I have posted a version of Solex_ser_recon_EN which includes AVI support, as well as a tweaked version of the prom images. It can be found on github here:
https://github.com/mattconsidine/Solex_ser_recon_AVI
@thesmiths : for reasons I don't understand I am not able to properly "fork" your project so that you can review the changes. My apologies - it's probably operator error on my part. That said, if you want to incorporate any of the changes, you are welcome to them.
mconsidine
EDIT on Aug 2, 2021 to correct URL
AVI support in SolEx SHG EN
-
- Oh, I get it now!
- Posts: 22
- Joined: Sun Aug 21, 2016 10:57 pm
- Been thanked: 13 times
AVI support in SolEx SHG EN
Last edited by mconsidine on Mon Aug 02, 2021 3:25 pm, edited 1 time in total.
-
- Oh, I get it now!
- Posts: 22
- Joined: Sun Aug 21, 2016 10:57 pm
- Been thanked: 13 times
Re: AVI support in SolEx SHG EN
I've fixed the issue I had with github. See my other post for the details. Code is now at
https://github.com/mattconsidine/Solex_ser_recon_AVI
mconsidine
EDITED (again) to reflect correct URL
https://github.com/mattconsidine/Solex_ser_recon_AVI
mconsidine
EDITED (again) to reflect correct URL
Last edited by mconsidine on Mon Aug 02, 2021 3:26 pm, edited 2 times in total.
-
- Almost There...
- Posts: 1053
- Joined: Mon Jun 04, 2012 8:13 pm
- Location: London, England
- Has thanked: 42 times
- Been thanked: 1485 times
Re: AVI support in SolEx SHG EN
Hi Matt, I think you got your GitHub accounts confused. Maybe correct the links, because it gives a "404".
I will have a check of the code before merging. We're away on holiday now and don't think I dare do a merge when away from my desktop.
Thanks for correcting some of the minor errors. Also, did you figure out what the 65000 (scalemax in your version) was all about?
Am I right in assuming your version also supports 8bit as well as 16bit (for both SER and AVI) ? I know that's what Ken was asking about previously.
I will have a check of the code before merging. We're away on holiday now and don't think I dare do a merge when away from my desktop.
Thanks for correcting some of the minor errors. Also, did you figure out what the 65000 (scalemax in your version) was all about?
Am I right in assuming your version also supports 8bit as well as 16bit (for both SER and AVI) ? I know that's what Ken was asking about previously.
-
- Oh, I get it now!
- Posts: 22
- Joined: Sun Aug 21, 2016 10:57 pm
- Been thanked: 13 times
Re: AVI support in SolEx SHG EN
Hi,
Yup, I goofed on my URLs. The one from which I posted the pull request is
https://github.com/mattconsidine/Solex_ser_recon_AVI
The 65000 is just a maximum value to which pixel values can be scaled for 16bit data. I switched it 65535, since that won't present any issue. I got the sense in reading the code that 65000/64000 was somewhat arbitrary. For 8bit data I set the similar value to ... you guessed it ... 255.
Yes, my version supports both 8bit and 16bit. All my code is "additive" , ie I didn't remove anything you/Valerie/others have done. So the command-line interface is also there, with the addition that it should also accept .AVI on that line as well.
EDIT: actually, I also commented out the block of code that creates the prom image and substituted my own. You can just as easily comment out my block and uncomment what was there before.
Ken has tested my code and it has worked for him as well, it seems. I tested it on AVIs converted from SER files.
Totally understand the idea of not making a change while on vacation, with a cell phone in one hand and an umbrella-drink in the other ...
mconsidine
Yup, I goofed on my URLs. The one from which I posted the pull request is
https://github.com/mattconsidine/Solex_ser_recon_AVI
The 65000 is just a maximum value to which pixel values can be scaled for 16bit data. I switched it 65535, since that won't present any issue. I got the sense in reading the code that 65000/64000 was somewhat arbitrary. For 8bit data I set the similar value to ... you guessed it ... 255.
Yes, my version supports both 8bit and 16bit. All my code is "additive" , ie I didn't remove anything you/Valerie/others have done. So the command-line interface is also there, with the addition that it should also accept .AVI on that line as well.
EDIT: actually, I also commented out the block of code that creates the prom image and substituted my own. You can just as easily comment out my block and uncomment what was there before.
Ken has tested my code and it has worked for him as well, it seems. I tested it on AVIs converted from SER files.
Totally understand the idea of not making a change while on vacation, with a cell phone in one hand and an umbrella-drink in the other ...
mconsidine
Last edited by mconsidine on Mon Aug 02, 2021 3:27 pm, edited 1 time in total.
- Merlin66
- Librarian
- Posts: 3970
- Joined: Tue Dec 13, 2011 1:23 pm
- Location: Junortoun, Australia
- Has thanked: 173 times
- Been thanked: 615 times
- Contact:
Re: AVI support in SolEx SHG EN
Yeah, definitely works OK with 8bit AVI files.
"Astronomical Spectroscopy - The Final Frontier" - to boldly go where few amateurs have gone before
https://groups.io/g/astronomicalspectroscopy
http://astronomicalspectroscopy.com
"Astronomical Spectroscopy for Amateurs" and
"Imaging Sunlight - using a digital spectroheliograph" - Springer
https://groups.io/g/astronomicalspectroscopy
http://astronomicalspectroscopy.com
"Astronomical Spectroscopy for Amateurs" and
"Imaging Sunlight - using a digital spectroheliograph" - Springer